Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Relates to Closed PR #1134 and Issue #674. Add suri_path and password_path options to CLI #1602

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ltfschoen
Copy link

@ltfschoen ltfschoen commented Apr 18, 2024

Summary

Closes #674

  • y | Does it introduce breaking changes?
  • n | Is it dependent on the specific version of ink or pallet-contracts?

See description here #1134 (comment)

Allows user to provide either suri + password, or suri_path + password_path

Status

TODO's are included in the PR that I haven't been able to resolve, so I can't compile and update Cargo.lock

Description

Re-open PR #1134 that was previously closed.
See description here #1134 (comment)

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signing: safer alternative for value bearing chains
1 participant